bug [salsa-macros]: Improve debug name of tracked methods #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #755 will not alter performanceComparing Summary
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
MichaReiser
force-pushed
the
improve-tracked-method-debug-name
branch
from
9628ac8 to
47ffa16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The debug name of every tracked method always was
inner_fn_name. This PR improves the function name to be<fn_name>_. This is not perfect but much more useful than the same name for every tracked method.An alternative is to use
std::any::type_nameand we could then try to detect if the type name is from aTrackedTraitbut that seems complicated.