Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imply verified_final field via cycle_heads state #762

Closed
wants to merge 1 commit into from

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Mar 16, 2025

No description provided.

Copy link

netlify bot commented Mar 16, 2025

Deploy Preview for salsa-rs canceled.

Name Link
🔨 Latest commit 35e0166
🔍 Latest deploy log https://app.netlify.com/sites/salsa-rs/deploys/67d6b04ff710a90008071f31

Copy link

codspeed-hq bot commented Mar 16, 2025

CodSpeed Performance Report

Merging #762 will degrade performances by 6.73%

Comparing Veykril:veykril/push-slrpxwwktqsn (35e0166) with master (c76b9e5)

Summary

⚡ 1 improvements
❌ 4 regressions
✅ 7 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
accumulator 3.4 ms 3.3 ms +3.02%
amortized[Input] 3.5 µs 3.6 µs -4.22%
amortized[InternedInput] 3.3 µs 3.6 µs -6.73%
amortized[SupertypeInput] 4.2 µs 4.4 µs -5.03%
new[InternedInput] 5.2 µs 5.5 µs -4.95%

@Veykril Veykril force-pushed the veykril/push-slrpxwwktqsn branch from d9773a4 to 35e0166 Compare March 16, 2025 11:04
@Veykril Veykril closed this Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant