Skip to content

Remove some unnecessary dynamic dispatch calls #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Apr 19, 2025

Just want to quickly check whether the optimize sees through this properly or not

Copy link

netlify bot commented Apr 19, 2025

Deploy Preview for salsa-rs canceled.

Name Link
🔨 Latest commit fb6ff4f
🔍 Latest deploy log https://app.netlify.com/sites/salsa-rs/deploys/68038c5ae6aba6000877ce8d

Copy link

codspeed-hq bot commented Apr 19, 2025

CodSpeed Performance Report

Merging #802 will not alter performance

Comparing Veykril:veykril/push-vnokuklytvwt (fb6ff4f) with master (ab7ecb4)

Summary

✅ 12 untouched benchmarks

@Veykril Veykril force-pushed the veykril/push-vnokuklytvwt branch 2 times, most recently from 913390e to 911f8f8 Compare April 19, 2025 10:37
@Veykril Veykril force-pushed the veykril/push-vnokuklytvwt branch 2 times, most recently from 11767e1 to 76ac72d Compare April 19, 2025 11:30
@Veykril Veykril changed the title Allow immediately resolving cycles with a fallback instead of fixpoint Remove some unnecessary dynamic dispatch calls Apr 19, 2025
@Veykril Veykril force-pushed the veykril/push-vnokuklytvwt branch from 76ac72d to fb6ff4f Compare April 19, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant