Fixes deprecated usage of node.path.orignal in htmlbars-plugin
#321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could also change the check for literal's to either endsWith 'Literal', or check only for |
| @@ -62,15 +62,15 @@ module.exports = class ClassTransformPlugin { | |||
| } | |||
|
|
|||
| transformStatement(node) { | |||
| if (node.path.original === 'local-class') { | |||
| if (!this.isNodePathLiteral(node.path) && node.path.original === 'local-class') { | |||
There was a problem hiding this comment.
Shouldn't we fix this differently by using either .original or .value?
There was a problem hiding this comment.
Honestly it's been so long since I've looked at this issue, I can't tell you what I expected to see anymore, but suspect it was just the warning "spew" as you say in your attempt.
|
This was my attempted fix #322 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
originalproperty on literal nodes is deprecated: https://github.com/glimmerjs/glimmer-vm/blob/10eae7429b702b1e7f5434b91802d5767ff7ad9a/packages/%40glimmer/syntax/lib/v1/legacy-interop.ts#L130This PR adds a check to see whether the path is one of the literal node paths, and if so does not access the
originalproperty