Skip to content

Send scores#165

Open
littlewhywhat wants to merge 2 commits into
add-scores-in-matchesfrom
send-scores
Open

Send scores#165
littlewhywhat wants to merge 2 commits into
add-scores-in-matchesfrom
send-scores

Conversation

@littlewhywhat

@littlewhywhat littlewhywhat commented May 29, 2020 •
edited
Loading

Copy link
Copy Markdown
  • send scores 1:0 or 0:1 instead of boolean team1Won
  • add e2e tests to check that match is recorded in match lists - both component in dashboard and the page

Send scores
59b08b2 
Signed-off-by: Roman Vaivod <romanv@salsitasoft.com>
@jkotrlik jkotrlik temporarily deployed to foosball-dev-pr-165 May 29, 2020 21:09 Inactive
@littlewhywhat littlewhywhat marked this pull request as ready for review June 6, 2020 07:18
@littlewhywhat littlewhywhat self-assigned this Jun 6, 2020
@jkotrlik jkotrlik temporarily deployed to foosball-dev-pr-165 June 15, 2020 13:29 Inactive
@novellizator novellizator marked this pull request as draft July 3, 2020 12:17
@littlewhywhat littlewhywhat marked this pull request as ready for review July 3, 2020 13:55
@littlewhywhat

littlewhywhat commented Jul 3, 2020

Copy link
Copy Markdown
Author

looks like it's ready - there is even an e2e test to be sure that things work :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@novellizator novellizator Awaiting requested review from novellizator

@petrk-salsita petrk-salsita Awaiting requested review from petrk-salsita

Assignees

@littlewhywhat littlewhywhat

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@littlewhywhat @jkotrlik