Skip to content

Fix "grant" revokes issues#22

Open
lvinagre wants to merge 2 commits intosalt-extensions:mainfrom
lvinagre:main
Open

Fix "grant" revokes issues#22
lvinagre wants to merge 2 commits intosalt-extensions:mainfrom
lvinagre:main

Conversation

@lvinagre
Copy link
Copy Markdown

@lvinagre lvinagre commented Jun 4, 2025

What does this PR do?

What issues does this PR fix or reference?

Fixes

Previous Behavior

  • Revokes were failing
Did not write failed 'REVOKE SELECT ON `underscore\_db`.*`
  • "escape" param was not being passed to grants_revoke

New Behavior

  • Revoke works as expected
Grant SELECT on underscore_db for testuser@172.%' has been revoked
  • "escape" param is being passed along

Merge requirements satisfied?

[NOTICE] Bug fixes or new features require tests.

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@lvinagre
Copy link
Copy Markdown
Author

lvinagre commented Jun 4, 2025

Just for reference, output from the current tests are 333 passed, 66 skipped, 4 warnings, 300 subtests passed

@lvinagre
Copy link
Copy Markdown
Author

Hey @lkubb, sorry to tag you again, but I feel you can either help or know who can help. Also, I am not sure I missed marking something on the PR for its review to move forward. Thank you once more!

@lkubb lkubb self-assigned this Jun 22, 2025
@lkubb
Copy link
Copy Markdown
Member

lkubb commented Jun 22, 2025

@lvinagre You're good, sadly there is no dedicated maintainer for this extension and I was on vacation. Will take a look at this next week!

@lvinagre
Copy link
Copy Markdown
Author

Hey @lkubb, I just wanted to check if you had the chance to look into this. 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants