Open
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this is a very interesting extension! Thought I'd help with the template update since the Renovate PR has many conflicts (because of modified action versions in workflow files).
I noticed
python_requireswas set to3.12, but the project actually advertises3.9inpyproject.toml. I changed it to3.10since that's what the new template version requires. Note that this input version is used in several places, including thepyupgradehook inpre-commit, which could render the code incompatible with versions lower than 3.12.Just as a general guidance, I can recommend keeping changes to generated files to the necessary minimum to simplify keeping up with template updates.
What does this PR do?
python_requiresanswer from3.12to3.10What issues does this PR fix or reference?
Fixes: #1
Merge requirements satisfied?
[NOTICE] Bug fixes or new features require tests.
Commits signed with GPG?
Yes