This is fix for #182 - Dependency problem in linux/system/selinux.sls.#185
Open
wasfree wants to merge 2 commits intosalt-formulas:masterfrom
Open
This is fix for #182 - Dependency problem in linux/system/selinux.sls.#185wasfree wants to merge 2 commits intosalt-formulas:masterfrom
wasfree wants to merge 2 commits intosalt-formulas:masterfrom
Conversation
…m/selinux.sls.
- This change will remove dependecy from linux/system/repo.sls in linux/system/selinux.sls.
- It also change structure from pillars selinux
old:
linux:
system:
...
selinux: permissive
new:
linux:
system:
...
selinux:
pkgs: ['policycoreutils', 'policycoreutils-python'],
mode: permissive
Member
|
This is not backward compatible so all pillars using |
Contributor
Author
Contributor
Author
|
@fpytloun ok, let me check if we can make it also backward compatible |
- We will check now if pillar system.selinux is a map for new format - If system.selinux is not a map use old format - policycoreutils and policycoreutils-python are not nessasary for basic selinux configuration we need this packages later to add selinux rules. - Added new format to test pillars
Contributor
Author
|
Hi @fpytloun, please check now, it is possible to use old pillar and new pillar format. We check in system.selinux if it is a map or not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
old:
linux:
system:
...
selinux: permissive
new:
linux:
system:
...
selinux:
pkgs: ['policycoreutils', 'policycoreutils-python'],
mode: permissive