Skip to content

Conversation

@ixs
Copy link
Contributor

@ixs ixs commented Apr 7, 2022

Change mpm.conf template for RedHat family systems.

The code currently written will always expand to true as a pillar.get() call will return None in case the pillar is non existing, which is also considered defined.
Fix this.

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

Change mpm.conf template for RedHat family systems.

The code currently written will always expand to true as a pillar.get() call will return None in case the pillar is non existing, which is also considered defined.
Fix this.
@ixs ixs requested a review from noelmcloughlin as a code owner April 7, 2022 22:24
@myii
Copy link
Contributor

myii commented Apr 8, 2022

@ixs Thanks for the PR. It would be helpful if you can adjust the commit message title to something like:

-Update 00-mpm.conf.jinja
+fix(00-mpm.conf.jinja): update RedHat template

That will enable semantic-release to work properly and allow the CI to run automatically (I've triggered it manually for now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants