Skip to content

Conversation

@Logioniz
Copy link

@Logioniz Logioniz commented Apr 13, 2018

Wrong dump python object with quotes (need double quotes)

Actual behavior

Pillar:

collectd:
  plugins:
    python:
      modules:
        elasticsearch:
          variables:
            AdditionalMetrics: [""]

Generated file:

    <Module "elasticsearch">
        AdditionalMetrics ['']
        ...
    </Module>

Error

collectd[1581]: configfile: Cannot read file `/etc/collectd/plugins/python.conf'.
systemd[1]: Unit collectd.service entered failed state.
collectd[1581]: ['']

Expected behavior

    <Module "elasticsearch">
        AdditionalMetrics [""]
        ...
    </Module>

{%- elif value is sequence %}
{{ key }} {{ value | json() }}
{%- else %}
{{ key }} {{ value }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same as on line 26, you could therefore simply test for is sequence and have a single else branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants