Adding the Sphinx sitemap #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@lumenCodes Can you rebase your branch with the latest updates from main? I've added some updates to |
lumenCodes
force-pushed
the
user-guide-sitemap
branch
from
ef827b4 to
8b19dbc
Compare
Contributor
Author
|
I have rebased the branch @scriptautomate-bc |
scriptautomate-bc
requested changes
May 2, 2025
Contributor
scriptautomate-bc
left a comment
scriptautomate-bc
left a comment
There was a problem hiding this comment.
A few changes being requested. After getting these changes in, make sure your next git commit is done as normal so that pre-commit can auto-apply the remaining fixes it wants to apply for the pre-commit tests to pass.
Contributor
|
Looks good! I'll do a follow-up PR that should resolve some other problems with the repo, which will improve the sitemap that is now getting generated. |
scriptautomate-bc
approved these changes
May 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have updated the conf.py file by adding
sphinx_sitemapto the extension. I also added thebaseurl.But the tests failed.
This will fix the issue #1