new feature: refactor server-side PKI #67799
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwoz
reviewed
Mar 8, 2025
twangboy
previously approved these changes
May 7, 2025
|
@twangboy appreciate the approve but still working on this one 👍 have some unaccounted for work with the cluster mode i need to look at as well as the current failing tests (also need to add more coverage) |
twangboy
changed the title
|
I added |
mattp-
changed the title
|
@twangboy sorry had to remove the label, something weird is going on with the github actions; i need the tests to run but its being wonky. will keep poking at it |
the end goal of this work is to support a non file/disk based interface for pub key management. Using the existing salt.cache interface allows us to leverage existing implementations of other storage backends (ie mysql, postgres, redis, etc). Of note, this will allow a common shared view of pub keys for multi-master setups. To avoid a break-the-world scenario in this change, a fully backward compatible salt.cache.localfs_key_backcompat is provided as the new default that emulates the disk operations salt.key was doing before. open discussion items: - as is i've left master side pub/priv key as is to live in etc/salt/pki; it COULD be moved to the same interface if thats desired
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The end goal of this work is to support a non file/disk based interface for pub key management. Using the existing salt.cache interface allows to leverage existing implementations of other storage backends (ie mysql, postgres, redis, etc).
Of note, this will allow a common shared view of pub keys for multi-master setups.
To avoid a break-the-world scenario in this change, a fully backward compatible salt.cache.localfs_key_backcompat is provided as the new default that emulates the disk operations salt.key was doing before.
open discussion items:
- as is i've left master side pub/priv key as is to live in etc/salt/pki; it COULD be moved to the same interface if that's desired
Tests written?
Not yet, pushing to see what CI does
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.