Skip to content

Conversation

@bdrx312
Copy link
Contributor

@bdrx312 bdrx312 commented Oct 4, 2025

Also add some more type hints and change some format calls to f strings. Fix state retry tests with invalid assumptions of duration and comment.

What does this PR do?

Adds the ability to specify arguments to a state as a dictionary instead of having to specify a list of individual key: value pairs

What issues does this PR fix or reference?

Fixes #68367

Previous Behavior

Could only specify arguments to a state like this

id1:
  cmd.run:
    - name: echo testing
    - umask: '0'

New Behavior

Can specify arguments to a state like this

id1:
  cmd.run:
    name: echo testing
    umask: '0'

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

No

@bdrx312 bdrx312 requested a review from a team as a code owner October 4, 2025 02:50
@bdrx312 bdrx312 force-pushed the support_state_args_dict branch from b2a27d9 to a8b7362 Compare October 4, 2025 18:09
@barneysowood barneysowood added the test:full Run the full test suite label Oct 5, 2025
Also add some more type hints and change some format calls to f strings.
Fix state retry tests with invalid assumptions of duration and comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:full Run the full test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants