add V1 task creation for windows schedule tasks#68983
Open
nychef wants to merge 4 commits intosaltstack:masterfrom
Open
add V1 task creation for windows schedule tasks#68983nychef wants to merge 4 commits intosaltstack:masterfrom
nychef wants to merge 4 commits intosaltstack:masterfrom
Conversation
bdrx312
reviewed
Apr 23, 2026
| # Check for required kwargs | ||
| if kwargs.get("subscription", False): | ||
| trigger.Id = "Event_ID1" | ||
| trigger.Id = "Event_{}".format(kwargs.get("subscription")) |
Contributor
There was a problem hiding this comment.
Use f string instead of .format: f"Event_{kwargs['subscription']}"
Author
|
changelog added as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add the ability to create V1 scheduled tasks in Windows using the compatibility argument
What issues does this PR fix or reference?
Fixes
Previous Behavior
All tasks were V2 tasks
New Behavior
The default is V2 but this can be overriden with the compatibility argument
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No