Fix circular reference issues with OptsDict/NamedLoaderContext#69005
Open
lkubb wants to merge 2 commits intosaltstack:3008.xfrom
Open
Fix circular reference issues with OptsDict/NamedLoaderContext#69005lkubb wants to merge 2 commits intosaltstack:3008.xfrom
lkubb wants to merge 2 commits intosaltstack:3008.xfrom
Conversation
lkubb
changed the title
lkubb
force-pushed
the
fix-optsdict-loadercontext
branch
from
3e1136b to
175a422
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes
safe_opts_copyaccount for being passed aNamedLoaderContextinstance by unwrapping its current value before returning the derivative dict.Note:
What issues does this PR fix or reference?
Fixes: #68973
Previous Behavior
Possible circular references because an OptsDict could become its own base transitively via a
NamedLoaderContextinstance returning it.New Behavior
NamedLoaderContextinstances are resolved before creating a derivative dict.Merge requirements satisfied?
Commits signed with GPG?
Yes