Document tls internal hot-reload behavior#55
Open
chrislearn wants to merge 1 commit into
Open
Conversation
The previous PR shipped resolver fixes for the ACME-gating rule and the ability to bootstrap the local CA mid-run on reload, but only the ACME-gating rule was already mentioned in the docs (it was the documented intent — the fix just made the code match). The reload story for `tls internal` was not covered. - en: Add a `tls internal` bullet to the existing Hot Reload section. - zh: Add a `### 热重载行为` subsection inside the 本地 CA section, since the Chinese doc does not have a top-level Hot Reload section. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #54: document the
tls internalreload story.The fix commit on #54 made two changes:
tls { internal }fallback so it only kicks in when ACME is not configured.local_caswappable andglobal_internalatomic, so a hot reload can bootstrap the local CA mid-run when a site flips totls internal.(1) was already promised in the docs (the original PR text said "The global form only takes effect when ACME is not configured") — the fix just made the code match. (2), on the other hand, is a new user-visible reload behavior that was never documented. This PR fixes that.
Local CA (tls internal)bullet to the existing Hot Reload section in docs/en/tls-and-acme.md.### 热重载行为subsection inside the 本地 CA section in docs/zh/tls-and-acme.md, since the Chinese doc does not have a top-level Hot Reload section.Test plan
🤖 Generated with Claude Code