resources: support PVC sub paths deeper than one level#375
Open
twelho wants to merge 1 commit intosamba-in-kubernetes:masterfrom
Open
resources: support PVC sub paths deeper than one level#375twelho wants to merge 1 commit intosamba-in-kubernetes:masterfrom
twelho wants to merge 1 commit intosamba-in-kubernetes:masterfrom
Conversation
There does not seem to be a technical limitation for doing this, other than complexity involving path validation. This uses a defense-in-depth approach with an (admittedly somewhat complex) regex to prevent path escapes, coupled with a manual bounds check if the CR is applied without validation.
Author
|
Simplified the validation regex since negative lookahead is not supported. This is not as extensive, but should still serve its purpose. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There does not seem to be a technical limitation for doing this, other than complexity involving path validation. This uses a defense-in-depth approach with an (admittedly somewhat complex) regex to prevent path escapes, coupled with a manual bounds check if the CR is applied without validation.