WIP: Added context support and tests for Subscription#118
WIP: Added context support and tests for Subscription#118intojhanurag wants to merge 2 commits intosamber:mainfrom
Conversation
|
Hey @samber , It is ready for review. |
|
In your implementation, there is currently no context propagation. I think you should find a clever way to return either Teardown or TeardownWithContext types in operators. If not possible, return only TeardownWithContext and propagate context. |
|
Hey @samber , Can you review my latest approach? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
==========================================
- Coverage 62.28% 61.75% -0.54%
==========================================
Files 76 76
Lines 9485 9554 +69
==========================================
- Hits 5908 5900 -8
- Misses 3492 3568 +76
- Partials 85 86 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Create a unit test for context propagation on unsubscription and you will understand why this PR is not finished. |
Make sense :) |
fixes: #115