Skip to content

feat: add plugin for time #215

Merged
samber merged 26 commits intosamber:mainfrom
BenjaminGoehry:main
Jan 10, 2026
Merged

feat: add plugin for time #215
samber merged 26 commits intosamber:mainfrom
BenjaminGoehry:main

Conversation

@BenjaminGoehry
Copy link
Copy Markdown
Contributor

No description provided.

@BenjaminGoehry BenjaminGoehry changed the title toto feat: add plugin for time Jan 8, 2026
@BenjaminGoehry BenjaminGoehry marked this pull request as ready for review January 9, 2026 16:48
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.32%. Comparing base (e745bd2) to head (4a71e01).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
+ Coverage   68.18%   68.32%   +0.13%     
==========================================
  Files          76       81       +5     
  Lines        8563     8599      +36     
==========================================
+ Hits         5839     5875      +36     
  Misses       2627     2627              
  Partials       97       97              
Flag Coverage Δ
unittests 68.32% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Owner

@samber samber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work on this package.

Just a few comments ;)

@BenjaminGoehry
Copy link
Copy Markdown
Contributor Author

Hi @samber ,
Thanks for the review! I've addressed all comments:

  • Added doc comments with embedded examples for all helpers
  • Fixed Parse to use ro.MapErr with proper error propagation
  • Renamed InTimeZone to In, matching stdlib naming

@samber samber merged commit a6ee939 into samber:main Jan 10, 2026
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants