Skip to content

chore(ci): improve go version management in CI#227

Merged
samber merged 1 commit intomainfrom
chore/improve-ci-go-version
Feb 21, 2026
Merged

chore(ci): improve go version management in CI#227
samber merged 1 commit intomainfrom
chore/improve-ci-go-version

Conversation

@samber
Copy link
Copy Markdown
Owner

@samber samber commented Feb 21, 2026

No description provided.

Copilot AI review requested due to automatic review settings February 21, 2026 17:07
@claude
Copy link
Copy Markdown

claude bot commented Feb 21, 2026

Claude finished @samber's task in 58s —— View job


Review Summary

I've reviewed the CI changes. Overall, these are good improvements to Go version management, but I have one concern.

✅ Good Changes

  1. Centralized Go version (lint.yml, release.yml): Moving from hardcoded versions to go-version-file: 'go.work' is the recommended practice. This ensures consistency and makes version updates easier.

  2. Fixed setup-go order (lint.yml): Moving checkout before setup-go is correct - go-version-file requires the file to exist first.

  3. Updated test matrix (test.yml): Replacing deprecated "1.x" with specific versions ("1.26", "stable") is the correct approach for setup-go@v6.

  4. Coverage condition (test.yml): Running coverage on "stable" instead of the oldest version makes more sense.

⚠️ Concern

test.yml - Disabled pull_request trigger:

 on:
   push:
-  pull_request:
+  # pull_request:

This disables tests from running on pull requests, which means PRs won't have automated test feedback. Is this intentional? If the goal was to reduce CI load, consider using paths filters or concurrency groups instead.

@samber samber merged commit 457a622 into main Feb 21, 2026
15 of 17 checks passed
@samber samber deleted the chore/improve-ci-go-version branch February 21, 2026 17:10
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.85%. Comparing base (62e0363) to head (52e6925).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #227      +/-   ##
==========================================
- Coverage   68.32%   64.85%   -3.47%     
==========================================
  Files          81       95      +14     
  Lines        8599     9055     +456     
==========================================
- Hits         5875     5873       -2     
- Misses       2627     3085     +458     
  Partials       97       97              
Flag Coverage Δ
unittests 64.85% <ø> (-3.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes Go version management in CI workflows by transitioning from hardcoded version numbers to using the go.work file as the source of truth, and updating the test matrix to use the "stable" version specifier instead of "1.x". The changes improve maintainability by centralizing version configuration.

Changes:

  • Migrated release.yml and lint.yml workflows to use go-version-file: 'go.work' instead of hardcoded versions
  • Updated test matrix to replace "1.x" with "stable" and added Go 1.24-1.26 to the version matrix
  • Fixed step ordering in lint.yml to checkout code before setting up Go (required for go-version-file)
  • Changed coverage reporting to run on "stable" version instead of "1.18"

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/test.yml Updated test matrix versions, changed coverage condition to use "stable", and commented out pull_request trigger
.github/workflows/release.yml Switched from hardcoded Go 1.18 to using go-version-file referencing go.work
.github/workflows/lint.yml Switched from hardcoded Go 1.18.0 to using go-version-file and fixed step ordering by moving checkout before setup-go

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants