chore(ci): improve go version management in CI#227
Conversation
|
Claude finished @samber's task in 58s —— View job Review SummaryI've reviewed the CI changes. Overall, these are good improvements to Go version management, but I have one concern. ✅ Good Changes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #227 +/- ##
==========================================
- Coverage 68.32% 64.85% -3.47%
==========================================
Files 81 95 +14
Lines 8599 9055 +456
==========================================
- Hits 5875 5873 -2
- Misses 2627 3085 +458
Partials 97 97
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR modernizes Go version management in CI workflows by transitioning from hardcoded version numbers to using the go.work file as the source of truth, and updating the test matrix to use the "stable" version specifier instead of "1.x". The changes improve maintainability by centralizing version configuration.
Changes:
- Migrated
release.ymlandlint.ymlworkflows to usego-version-file: 'go.work'instead of hardcoded versions - Updated test matrix to replace "1.x" with "stable" and added Go 1.24-1.26 to the version matrix
- Fixed step ordering in
lint.ymlto checkout code before setting up Go (required for go-version-file) - Changed coverage reporting to run on "stable" version instead of "1.18"
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/test.yml |
Updated test matrix versions, changed coverage condition to use "stable", and commented out pull_request trigger |
.github/workflows/release.yml |
Switched from hardcoded Go 1.18 to using go-version-file referencing go.work |
.github/workflows/lint.yml |
Switched from hardcoded Go 1.18.0 to using go-version-file and fixed step ordering by moving checkout before setup-go |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.