Skip to content

Bump up prisma v7, and lots of changes - #428

Merged
samchon merged 3 commits into
masterfrom
prisma-v7
Nov 24, 2025
Merged

Bump up prisma v7, and lots of changes#428
samchon merged 3 commits into
masterfrom
prisma-v7

Conversation

@samchon

@samchon samchon commented Nov 24, 2025

Copy link
Copy Markdown
Owner

This pull request updates the project to use Prisma 7 and refactors the codebase to align with the new SDK and best practices. The changes touch dependency management, Prisma schema configuration, and TypeScript usage patterns throughout the providers, improving compatibility and maintainability.

Dependency and SDK Upgrades:

  • Updated package.json dependencies to use Prisma 7 (@prisma/client, prisma, @prisma/adapter-pg, and added @prisma/internals). Also upgraded prisma-markdown to v4.0.0. [1] [2]

Prisma Schema and Output Configuration:

  • Changed the Prisma generator in main.prisma to use the new provider (prisma-client), set the output directory, and removed the engine type, aligning with Prisma 7 conventions.

Codebase Refactoring for Prisma 7:

  • Replaced all imports of Prisma and PrismaClient from @prisma/client with imports from @prisma/sdk or relevant updated packages across all provider files and configuration files. [1] [2] [3] [4] [5] [6] [7] [8] [9]

TypeScript Usage Pattern Updates:

Entity Merge Provider Modernization:

  • Updated EntityMergeProvider to use new Prisma internals for schema merging and DMMF access, replacing old imports and patterns for compatibility with Prisma 7. [1] [2]

@samchon
samchon requested a review from Copilot November 24, 2025 15:09
@samchon samchon self-assigned this Nov 24, 2025
@samchon samchon added enhancement New feature or request dependencies Pull requests that update a dependency file labels Nov 24, 2025
@socket-security

socket-security Bot commented Nov 24, 2025

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​prisma/​internals@​7.0.0941007698100
Updated@​prisma/​adapter-pg@​6.19.0 ⏵ 7.0.010010083 +198 +1100
Updated@​prisma/​client@​6.19.0 ⏵ 7.0.099 +61008598100
Updatedprisma-markdown@​3.0.1 ⏵ 4.0.098 +210010089 +8100
Updatedprisma@​6.19.0 ⏵ 7.0.0941009798100

View full report

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the project to use Prisma 7, refactoring imports and type patterns throughout the codebase. However, there are several critical issues that need to be addressed before this PR can be merged.

Key Changes:

  • Updated Prisma dependencies to v7.0.0 and related packages
  • Refactored all Prisma type validators from Prisma.validator<T>()() to modern satisfies T pattern
  • Moved entity merge logic from EntityUtil into EntityMergeProvider with new Prisma 7 APIs
  • Changed Prisma client output directory to src/prisma

Reviewed changes

Copilot reviewed 13 out of 15 changed files in this pull request and generated 13 comments.

Show a summary per file
File Description
package.json Updated Prisma packages to v7.0.0 and added @prisma/internals
prisma/schema/main.prisma Modified generator configuration with new output path and removed database URL
tsconfig.json Added path mapping for @prisma/sdk to custom location
.gitignore Added src/prisma to ignore generated client files
src/utils/EntityUtil.ts Removed file - logic migrated to EntityMergeProvider
src/providers/common/EntityMergeProvider.ts Refactored to use @prisma/internals for schema operations and DMMF access
src/providers/common/*.ts Updated all imports to use @prisma/sdk and refactored to satisfies pattern
src/MyGlobal.ts Changed PrismaClient import to @prisma/sdk
src/MyConfiguration.ts Changed Prisma namespace import to @prisma/sdk
src/executable/schema.ts Changed PrismaClient import to @prisma/sdk

Critical Issues Found:

  • @prisma/sdk is not a valid npm package - all imports should use @prisma/client
  • Prisma schema generator provider should be "prisma-client-js" not "prisma-client"
  • Missing url field in datasource configuration will break Prisma CLI
  • Path mismatch: code references prisma/schemas but directory is prisma/schema
  • TypeScript path mapping points to non-existent client.ts file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/providers/common/BbsArticleProvider.ts
Comment thread src/providers/common/BbsArticleCommentSnapshotProvider.ts
Comment thread prisma/schema/main.prisma
Comment thread src/providers/common/EntityMergeProvider.ts
Comment thread src/providers/common/EntityMergeProvider.ts
Comment thread prisma/schema/main.prisma
Comment thread src/MyGlobal.ts
Comment thread src/executable/schema.ts
Comment thread src/MyConfiguration.ts
Comment thread src/providers/common/BbsArticleSnapshotProvider.ts
@samchon
samchon merged commit 81720f2 into master Nov 24, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants