functions: Fix fetch commits cron job#599
Closed
campisanoentaksi wants to merge 2 commits into
Closed
Conversation
Collaborator
|
Thanks for this update. Considering redmine hasn't changed this flow in 4 major versions, can you make this the default case handler so we don't have to keep updating it. |
Collaborator
|
Actually it makes more sense just to drop 2.x support and the whole case statement |
Contributor
Author
|
That makes sense to me, PR updated |
Collaborator
|
Released version 6.1.3-1. Do you need a 6.0 release? |
Contributor
Author
|
The 6.1.3-1 is fine, many thanks for the release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have the same issue described in #526, except that I'm upgrading from 5.* to 6.*.
In the PR I'm updating the
redmine_configure_fetch_commitsfunction to handle the case where${REDMINE_VERSION}is6.*