DRAFT: Fix propshaft theme support#600
Closed
jcormier wants to merge 2 commits into
Closed
Conversation
…ompile step Issue #591
There was a problem hiding this comment.
Pull request overview
This PR targets Issue #591 by improving Redmine 6.x theme handling in the container runtime, aiming to ensure theme assets are available under the /assets/themes/... path by syncing themes into the install tree and triggering asset compilation.
Changes:
- Only runs theme installation when the themes directory exists and is non-empty.
- Syncs themes into
${REDMINE_INSTALL_DIR}/themes/viarsyncwith ownership/permission adjustments. - Runs
assets:precompileafter themes are installed to generate theme assets.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| install_themes() { | ||
| if [[ -d ${REDMINE_THEMES_DIR} ]]; then | ||
| if [[ -d ${REDMINE_THEMES_DIR} && -n "$(ls -A ${REDMINE_THEMES_DIR})" ]]; then |
Comment on lines
+1189
to
+1191
| # if themes are installed, we need to precompile assets | ||
| echo "Precompiling assets. Please be patient, this could take a while..." | ||
| execute_raketask assets:precompile |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Collaborator
Author
|
Updated and merged changes manually |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #591