Normalize PICO-8 palette aliases and fix bitplane mask#47
Open
stilvoid wants to merge 2 commits into
Open
Conversation
PICO-8 masks screen palette entries before resolving the final display color, which means values such as 16..31 map back to the base palette and 240..255 map to the hidden palette. Apply the same normalization to screen and raster palette entries at render time so the canonical hidden range and its byte aliases resolve consistently.
aab90b9 to
ffe969e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PICO-8 masks screen palette entries before resolving the final display color, which means values such as 16..31 map back to the base palette and 240..255 map to the hidden palette.
Apply the same normalization to screen and raster palette entries at render time so the canonical hidden range and its byte aliases resolve consistently.
Additionally, fix bug assuming that bitplane mask is 3 bits instead of 4.