Skip to content

code review #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alifrumin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

code review #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/controllers/animals_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def sort
redirect_to animal_path(@animal, :sort_by => @sort_by)
end

# TODO: fix so does not delete if have doses?
# TODO: fix so does not delete if have doses?... you could do a dependent destroy in the model so it will delete animals with doses
def destroy
if @animal.doses
flash[:alert] = 'You cannot delete animals that have doses'
Expand Down
2 changes: 2 additions & 0 deletions app/views/animals/edit.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,5 @@
<% end %>

<%# TODO: Fix view with labels while still using form - JS? %>

<!-- you created a _form so you could make this dryer by doing render form -->
1 change: 1 addition & 0 deletions app/views/animals/index.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,3 +190,4 @@
</ul>
</div>
</div>
<!-- very cool animations -->
3 changes: 1 addition & 2 deletions db/schema.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
#
# It's strongly recommended that you check this file into your version control system.

ActiveRecord::Schema.define(version: 20151119051352) do
ActiveRecord::Schema.define(version: 20151118004355) do

# These are extensions that must be enabled in order to support this database
enable_extension "plpgsql"
Expand Down Expand Up @@ -42,7 +42,6 @@
t.string "route"
t.string "restrictions"
t.text "notes"
t.string "image_url"
end

create_table "roles", force: :cascade do |t|
Expand Down