Reformat and add "new sheet to document" function#29
Open
JulesCastel wants to merge 6 commits into
Open
Conversation
i wanted to be able to separate sensor readings by day and automate making a new tab in the document
Author
|
Forgot to mention, I also changed stuff in |
i can't believe i never fixed this before trying to submit a pull request oops
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed the ability to create a new sheet/tab to the document and couldn't find a way to do so, so I made my own way of doing it. I tested it on my own sheet and it seems to work fine, but further testing might be needed!
I also had a few nitpicks with the formatting of
gsheet.jsandgsheet.html, so I prettied them up as well to make it easier to read. There was also a typo with the word "flatten" (it was spelled as "flaten"), so I fixed that as well to prevent future headaches in case anybody else needs to work on it.The new function is in the example flow in
examples/Google Sheets.jsontoo, to show how it should be used.I'm new to contributing on GitHub btw, so please let me know if there's anything I might've missed here 🙏