-
Notifications
You must be signed in to change notification settings - Fork 2.3k
feat: Expose option for user to edit max_queue_size in websockets, have async callbacks called in a task and update docs #1570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pcriadoperez
commented
Mar 30, 2025
•
edited
Loading
edited
- Move MAX_QUEUE_SIZE from constant to variable set by user on starting ThreadedWebsocket or BinanceWebsocket
- Have async callbacks run in a task to better performance of slow async callbacks. (Before one had to finish before calling the next one)
- Fix passing keys and proxy to threaded socket manager
- Adds pytest-timeout and timeout of 60seconds for tests
- Add tests
- Update docs
- Increase verbosity in test running
- Comments coveralls: (Temporarily due to due to coveralls maintenance of April 6 2025: https://status.coveralls.io/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.