Skip to content

feat: Expose option for user to edit max_queue_size in websockets, have async callbacks called in a task and update docs #1570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Apr 7, 2025

Conversation

pcriadoperez
Copy link
Collaborator

@pcriadoperez pcriadoperez commented Mar 30, 2025

  • Move MAX_QUEUE_SIZE from constant to variable set by user on starting ThreadedWebsocket or BinanceWebsocket
  • Have async callbacks run in a task to better performance of slow async callbacks. (Before one had to finish before calling the next one)
  • Fix passing keys and proxy to threaded socket manager
  • Adds pytest-timeout and timeout of 60seconds for tests
  • Add tests
  • Update docs
  • Increase verbosity in test running
  • Comments coveralls: (Temporarily due to due to coveralls maintenance of April 6 2025: https://status.coveralls.io/)

@carlosmiei carlosmiei closed this Mar 31, 2025
@carlosmiei carlosmiei reopened this Mar 31, 2025
@carlosmiei carlosmiei self-assigned this Apr 3, 2025
@carlosmiei carlosmiei closed this Apr 3, 2025
@carlosmiei carlosmiei reopened this Apr 3, 2025
@pcriadoperez pcriadoperez reopened this Apr 6, 2025
@carlosmiei carlosmiei merged commit 9dac1d4 into sammchardy:master Apr 7, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants