Update Wasm tests - #1
Open
github-actions[bot] wants to merge 1 commit into
Open
Conversation
sammygill
pushed a commit
that referenced
this pull request
May 29, 2025
This is a preparation change to the upcoming change that disallows non-trustworthy plaintext HTTP prerendering. This CL now runs external/wpt/speculation-rules/ wpts over HTTPs. Bug: 340895233 Change-Id: Id820f192f5e973245c2dbbf1ca8daa5078abad78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6398184 Reviewed-by: Domenic Denicola <domenic@chromium.org> Reviewed-by: Fabio Rocha <fabio.rocha@microsoft.com> Commit-Queue: Jessica Chen <peiche@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1450755}
sammygill
pushed a commit
that referenced
this pull request
Oct 28, 2025
…& compile_module_script to fix the inline script reporting wrong line issue (web-platform-tests#39415) Originally, the function compile_module_script hardwires the value 1 when invoking CompileOptionsWrapper::new(). This is fine if the script is written in separate JS file, but for inline scripts, it will cause confusion if the <script> tag doesn't start from line #1. Credits to JDM for actually pointing out which functions to fix. Testing: There are WPT tests for this change, specifically: tests/wpt/tests/html/semantics/scripting-1/the-script-element/module/evaluation-error-5.html Signed-off-by: RichardTjokroutomo <richard.tjokro2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scheduled weekly update auto-generated by the 'Update Wasm tests' workflow.