Split up features & small fix for incomplete payloads (broken packages) #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- introduce python-bindings feature to enable bindings. this will activate the python-bindings feature in doip-definitions Signed-of-by: Elena Gantner <[email protected]>
- ensure that src.advance at most advances the remaining bytes in case of an incomplete message - fix small bug in creating payload slice calculation Signed-of-by: Elena Gantner <[email protected]>
theswiftfox
force-pushed
the
upstream_main
branch
from
d447035 to
ceaaec5
Compare
samp-reston
reviewed
Jun 26, 2025
Comment on lines
+197
to
+203
| let cnt = DOIP_HEADER_LEN + (header.payload_length as usize); | ||
| let advance_length = if src.remaining() >= cnt { | ||
| cnt | ||
| } else { | ||
| src.len() | ||
| }; | ||
| src.advance(advance_length); |
|
Should I use the upstream git rev of samp-reston/doip-definitions, or do you plan on a version bump on crates.io? (if so, I'd wait and change the rev to that version :) ) Edit: NVM, just saw the commit in doip-definitions |
- update std feature to also set the feature in doip-definitions dependency Signed-of-by: Elena Gantner <[email protected]>
|
@samp-reston I updated the dependencies to the latest doip-definitions crate |
|
Very good thank you for your contributions, feel free to create PRs too in future! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
similar to samp-reston/doip-definitions#29 this PR introduces the feature to split up python bindings from std.
Additionally the codec can now handle incomplete packages where the header.payload_length doesn't match the actual received package and ensures that src.advance does not try to advance more bytes than present.
Still a draft as the dependency has to be changed to the upstream again, once the PR in doip-definitions is merged :)Elena Gantner [email protected] on behalf of Mercedes-Benz Tech Innovation GmbH
Provider Information