Open
Conversation
alexanderkiel
requested changes
Jul 13, 2021
| @@ -1,7 +1,19 @@ | |||
| FROM maven:3.8.1-openjdk-11 AS build | |||
Member
There was a problem hiding this comment.
I would rather use GitHub Actions to build the JAR file instead of a build container. Please see https://github.com/samply/store-fhir-adapter/blob/main/.github/workflows/ci.yml
Member
Author
There was a problem hiding this comment.
I am not familiar with Actions, so it could be some time before I can make the requested change.
Would it be possible to incorporate the build container for the time being, and upgrade to GitHub Actions at a later date?
Dockerfile
Outdated
| RUN apk upgrade | ||
| RUN apk add bash | ||
| RUN apk add gettext | ||
| RUN apk add curl |
Member
There was a problem hiding this comment.
Why do we need curl here?
Member
Author
There was a problem hiding this comment.
Not needed - I have removed this.
Feature/default check
The main things added are: * A docker-compose.yml file, that builds the JAR and provides both the dictionary itself and also a database. * A Docker-based conversion tool for generating the dictionary in JSON format.
Added a README to the ICD10-GM directory Made the README.md more general, so that it will also work for the WHO dictionary.
...because I tried it out for real, and it didn't work!
alexanderkiel
force-pushed
the
icd10-gm-docker
branch
from
0d83871 to
36cfee2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.