Hotfix/refactor

[Martin1088]

Refactor app and provider creating

[Threated]

Not a fan of moving the secret generation to shared and also not a fan of creating a function for creating the secret based on public or private. What was the motivation for that?

[Martin1088]

Because secret generation was based with „if“ on the „is_public“ before. Like client_id.
And to put it in the same context and place.

[Threated]

Yeah I know that but

1. What does that have to do in shared it only concerns central
2. shared now has a dependency on rand for local for no reason
3. I am not a fan of putting hacky intransparent things like returning an empty string if its public in functions as it hides that information from the usage site and in this case it is only used twice

[Threated]

Why? You should probably add a #[cfg(test)] above the mod tests; in mod.rs which might solve some of your import issues

[Threated]

These clean ups are not that important and the diff is getting a bit messy now. Can you do this after my vacation and make a separate PR fixing the redirect url thing we discussed

[Martin1088]

Only basic the refactor fn
Created new request