Skip to content

fix angular universal #1631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix angular universal #1631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions gulpfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@ Object.entries(build.js).forEach(([filename, entry]) => {
),
)
.pipe(header('typeof navigator === "object" && ')) // "Support" SSR (#935)
.pipe(header('typeof document === "object" && ')) // "Support" SSR (#935)
.pipe(
rename({
extname: `.${extension}`,
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"homepage": "https://plyr.io",
"author": "Sam Potts <[email protected]>",
"main": "dist/plyr.js",
"module": "dist/plyr.min.mjs",
"jsnext:main": "dist/plyr.min.mjs",
"module": "dist/plyr.min.js",
"jsnext:main": "dist/plyr.min.js",
Comment on lines +8 to +9
Copy link
Owner

@sampotts sampotts Jan 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason behind this? This will use the ES5 code.

"browser": "dist/plyr.min.js",
"sass": "src/sass/plyr.scss",
"style": "dist/plyr.css",
Expand Down