refactor(bril-rs)!: Use a standalone struct for a concrete label
#350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanuppal
changed the title
struct for a concrete labelstruct for a concrete label
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
It would be useful to refer to a
Labelobject in source code usingbril-rsas a library. This can also be done on the user-level by transformingCode::Labelinto an appropriate user-definedstruct, so I can close this PR if this path is intended.Changes
Code::Labelvariant in the representation of a concrete program to instead hold a newLabelstruct, which contains the same information as the variant. This newstructalso implements the same traits and other properties as the other items.0.2to reflect this breaking change.