Skip to content

Conversation

@samschott
Copy link
Owner

@samschott samschott commented Nov 13, 2024

Instead of getting delivered notifications from our cache, get them directly from macOS APIs.

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.06%. Comparing base (26c6af2) to head (07b8fcd).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
src/desktop_notifier/backends/macos.py 71.42% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #198      +/-   ##
==========================================
- Coverage   85.13%   85.06%   -0.08%     
==========================================
  Files          10       10              
  Lines         895      904       +9     
==========================================
+ Hits          762      769       +7     
- Misses        133      135       +2     
Flag Coverage Δ
pytest 85.06% <71.42%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@samschott samschott force-pushed the get-real-current-notifications branch 3 times, most recently from dc96b7c to f188326 Compare November 13, 2024 21:10
@samschott samschott force-pushed the get-real-current-notifications branch from f188326 to 07b8fcd Compare November 23, 2024 19:24
@samschott samschott marked this pull request as ready for review November 23, 2024 19:29
@samschott samschott changed the title Get real current notifications Get real current notifications on macOS Nov 23, 2024
@samschott samschott merged commit ff32314 into main Nov 23, 2024
16 checks passed
@samschott samschott deleted the get-real-current-notifications branch November 23, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants