Skip to content

Conversation

@PhrozenByte
Copy link
Contributor

This truly freezes Notification instances

Resource.as_name() is necessary to make mypy happy, otherwise it always assumes that Resource.name might be None

This truly freezes Notification instances
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 87.17949% with 5 lines in your changes missing coverage. Please review.

Project coverage is 84.89%. Comparing base (26c6af2) to head (13638cd).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
src/desktop_notifier/main.py 71.42% 2 Missing ⚠️
src/desktop_notifier/sync.py 66.66% 2 Missing ⚠️
src/desktop_notifier/common.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
- Coverage   85.13%   84.89%   -0.25%     
==========================================
  Files          10       10              
  Lines         895      920      +25     
==========================================
+ Hits          762      781      +19     
- Misses        133      139       +6     
Flag Coverage Δ
pytest 84.89% <87.17%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PhrozenByte PhrozenByte mentioned this pull request Nov 26, 2024
8 tasks
Copy link
Owner

@samschott samschott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The current icon handling was indeed a bit of a hack.

@samschott samschott merged commit d6ce5b1 into samschott:main Nov 30, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants