Skip to content

DesktopNotifierSync: Add on_* properties for class-level events #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PhrozenByte
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 12 lines in your changes missing coverage. Please review.

Project coverage is 84.93%. Comparing base (5dab588) to head (94dfb9b).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
src/desktop_notifier/sync.py 66.66% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #207      +/-   ##
==========================================
- Coverage   85.06%   84.93%   -0.13%     
==========================================
  Files          10       10              
  Lines         951      976      +25     
==========================================
+ Hits          809      829      +20     
- Misses        142      147       +5     
Flag Coverage Δ
pytest 84.93% <66.66%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Owner

@samschott samschott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay in reviewing this! The change LGTM, just a minor request for change.

@PhrozenByte PhrozenByte force-pushed the enhancement/global-event-callbacks-sync branch from 90e7460 to 94dfb9b Compare April 9, 2025 12:40
@PhrozenByte
Copy link
Contributor Author

Done. Since you haven't had other comments about #208 I've updated this PR in anticipation of #208 as well. Meaning: You must merge #208 first, then re-run CI (mypy fails until #208 is merged, but should succeed then), and then merge this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants