Skip to content

Conversation

@dlech
Copy link
Contributor

@dlech dlech commented Apr 5, 2025

as_() has replaced _from() for "casting" WinRT objects to different types.

I just did this in the web editor, so I haven't tested it, but it should avoid the type error that was being ignored.

`as_()` has replaced `_from()` for "casting" WinRT objects to different types.
@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.06%. Comparing base (26c6af2) to head (8f82691).
Report is 39 commits behind head on main.

Files with missing lines Patch % Lines
src/desktop_notifier/backends/winrt.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #219      +/-   ##
==========================================
- Coverage   85.13%   85.06%   -0.08%     
==========================================
  Files          10       10              
  Lines         895      951      +56     
==========================================
+ Hits          762      809      +47     
- Misses        133      142       +9     
Flag Coverage Δ
pytest 85.06% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samschott
Copy link
Owner

Thanks! All tests pass, including type checking, so LGTM.

@samschott samschott merged commit 7c9dd7b into samschott:main Apr 5, 2025
35 checks passed
@dlech dlech deleted the patch-1 branch April 5, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants