Skip to content

Conversation

@dlech
Copy link
Contributor

@dlech dlech commented Apr 12, 2025

I just published PyWinRT v3.1.0 which fixes the crash that was being worked around, so we can drop the hack of casting the return value to a list.

I also removed the upper limit on the package versions. Experience has show than this can cause problems for people trying to use libraries. I don't expect v4 to have breaking API changes like v3 did anyway.

Finally, the Windows tests that were being skipped are passing for me locally, so not sure if that is something that got fixed too or if it depends on the actual Windows version. We'll see if it passes on CI.

PyWinRT v3.1 fixed the crash that was being worked around by by casting
the get_history_with_id() result to a list.

Update the minimal version of pywinrt to 3.1 and remove the list hack.
Also drop upper bound for packages versions as it can cause issues
for people consuming this library.
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.85%. Comparing base (5dab588) to head (ec87115).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #222      +/-   ##
==========================================
+ Coverage   85.06%   85.85%   +0.78%     
==========================================
  Files          10       10              
  Lines         951      940      -11     
==========================================
- Hits          809      807       -2     
+ Misses        142      133       -9     
Flag Coverage Δ
pytest 85.85% <100.00%> (+0.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Remove the decorators to skip tests on Windows. These tests seem to be
passing now.
@dlech dlech force-pushed the remove-list-hack branch from b5b9294 to ec87115 Compare April 12, 2025 23:59
@samschott
Copy link
Owner

I just published PyWinRT v3.1.0 which fixes the crash that was being worked around, so we can drop the hack of casting the return value to a list.

Thank you so much! I was planning to create a bug for this but did not get around to it yet.

I also removed the upper limit on the package versions. Experience has show than this can cause problems for people trying to use libraries. I don't expect v4 to have breaking API changes like v3 did anyway.

Thanks for the assurances. I much prefer not setting an upper limit as well.

Finally, the Windows tests that were being skipped are passing for me locally, so not sure if that is something that got fixed too or if it depends on the actual Windows version. We'll see if it passes on CI.

CI seems to pass. IIRC, this may have been an issue with how the remove API was called which was fixed in the last release.

@samschott samschott merged commit d38024f into samschott:main Apr 14, 2025
35 checks passed
@dlech dlech deleted the remove-list-hack branch April 14, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants