Change cli#8
Change cli#8TechMagister wants to merge 4 commits intosamueleaton:masterfrom TechMagister:change_cli
Conversation
|
When someone runs the |
|
|
||
| module Sentry | ||
|
|
||
| class SentryCommand < Cli::Command |
There was a problem hiding this comment.
I believe it is a Crystal standard to capitalize acronyms (e.g. CLI, HTTP, JSON)
There was a problem hiding this comment.
True, but I don't know if @mosop will change the name now :/
|
Also, the current CLI installation process does not use shards or dependencies, so we will need to figure that out. Correct me if I'm wrong, but I don't believe shards has support for installing CLI tools as a dependency. |
|
I updated the install.rb file to take in account the modifications. ( I completely forgot it 😝 ) |
|
Seeing as this will introduce a dependency, is there a way to install Sentry while installing dependencies at the same time? Does shards support that feature? I like what you did to |
|
Also they way you are loading the app name in the CLI dynamically is a no brainer. 👍 That will be much better. Glad I could get some other eyes on this project to help button it up. I would however make the |
|
You may want to look at Admiral as well: https://github.com/jwaldrip/admiral.cr |
Move from OptionParser to Cli for better integration