-
Notifications
You must be signed in to change notification settings - Fork 23
Refactor panel visibility logic #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Refactor panel visibility logic #307
Conversation
| availableTabs.includes(String(informationPanel.defaultTab)) && | ||
| informationPanel.defaultTab) || | ||
| availableTabs[0] || | ||
| "manifest-about"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering about this - is it worth falling back to a tab that just says something like "No tabs configured, consider adding one or disabling the toggle". Or maybe just disabling the toggle in this case?
|
Hi @body-clock. I've taken a peek at this and am seeing some issues with it automatically toggling back to the About tab if I attempted navigate to Annotations. I'll take a deeper look at other use cases but these are the two obvious ones I noted. For example, try wiring up either of these resources: vtt annotations for this item content state link for this item (with an annotation) |
Closes #306
pluginsWithInfoPanelfromInformationPaneltoViewer/Content(which rendersInformationPanel), pass it as a prop (so it isn't called twice)