Fix possible role relation a11y issues in transcript display #821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dananji
force-pushed
the
transcript-a11y-fixes
branch
from
ebb4899 to
1a5e9d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
radiogroup/radiorole relationship introduced in #820 for transcript cues as this could introduce role relationship errors similar to annotations component (#811) in the future. E.g. cues with links embedded in them could lead to a break in accessibility as they are presented within a parent container which has therole="radio".Changes included in the PR:
role="button", therefore only highlighting the timestamp on hover events