-
Notifications
You must be signed in to change notification settings - Fork 22
SharePoint provider #418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cziaarm
wants to merge
8
commits into
samvera:main
Choose a base branch
from
research-technologies:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
SharePoint provider #418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream merge
Sharepoint provider
2 tasks
masaball
added a commit
to avalonmediasystem/browse-everything
that referenced
this pull request
Sep 16, 2024
Refer to samvera#418 for what is being built off of.
masaball
added a commit
to avalonmediasystem/browse-everything
that referenced
this pull request
Jun 3, 2025
Refer to samvera#418 for what is being built off of.
masaball
added a commit
to avalonmediasystem/browse-everything
that referenced
this pull request
Dec 8, 2025
Co-authored-by: Rory McNicholl <[email protected]> Refer to samvera#418 for what is being built off of. Refer to v1.5-avalon branch for full info on squashed commits: - Implement authorization_code flow - Update SharePoint.md - Return all user accessible sharepoint sites - Add an option to filter what sites get returned - Use select param to limit returned metadata: We do not use every metadata field returned from the all sites and all drives queries. Using the select parameter to limit what gets returned to the handful of fields we need should increase the speed of the requests, resulting in faster loading. - Update documentation - Add tests for sharepoint driver - Enable permissions re-consent flow - Use joinedTeams as base folder instead of sites: The sites endpoint returns every single sharepoint site that a user has access to. This list can include many more options than a user would expect, including stuff that the user should technically not have access to (such as if a site has its permissions misconfigured). While we can use a $search param to narrow the results, we can only get so granular and so even the filtered results may provide an unwieldy amount of folders. Because IU is interested in uploading files that are stored on sharepoint drives that originate from Microsoft Teams, we use the `joinedTeams` endpoint to only return drives that a user is explicitly a member of. This creates a much more sensible and manageable list for users to browse through and one that should have no surprises for the user. - Update SharePoint.md - Initial Bootstrap 5 upgrade: This commit is to update the gem enough to load in Avalon Media System when running Bootstrap 5. Functionality and styling seem to be working but it has not been thoroughly tested. - Cleanup of documentation and code - Remove unneeded methods
masaball
added a commit
to avalonmediasystem/browse-everything
that referenced
this pull request
Dec 19, 2025
Co-authored-by: Rory McNicholl <[email protected]> Refer to samvera#418 for what is being built off of. Refer to v1.5-avalon branch for full info on squashed commits: - Implement authorization_code flow - Update SharePoint.md - Return all user accessible sharepoint sites - Add an option to filter what sites get returned - Use select param to limit returned metadata: We do not use every metadata field returned from the all sites and all drives queries. Using the select parameter to limit what gets returned to the handful of fields we need should increase the speed of the requests, resulting in faster loading. - Update documentation - Add tests for sharepoint driver - Enable permissions re-consent flow - Use joinedTeams as base folder instead of sites: The sites endpoint returns every single sharepoint site that a user has access to. This list can include many more options than a user would expect, including stuff that the user should technically not have access to (such as if a site has its permissions misconfigured). While we can use a $search param to narrow the results, we can only get so granular and so even the filtered results may provide an unwieldy amount of folders. Because IU is interested in uploading files that are stored on sharepoint drives that originate from Microsoft Teams, we use the `joinedTeams` endpoint to only return drives that a user is explicitly a member of. This creates a much more sensible and manageable list for users to browse through and one that should have no surprises for the user. - Update SharePoint.md - Initial Bootstrap 5 upgrade: This commit is to update the gem enough to load in Avalon Media System when running Bootstrap 5. Functionality and styling seem to be working but it has not been thoroughly tested. - Cleanup of documentation and code - Remove unneeded methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of a provider for SharePoint/OneDrive (basically MS graph)
When writing this there was no reliable MS graph ruby client gem (microsoftgraph/msgraph-sdk-ruby#69)
That may have now changed, so a TODO would be to integrate that if possible