Skip to content

TLS backend selection feature flags, Default, clippy #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

virtualritz
Copy link

  • Exposed reqwest's TLS backend selection features.
    The main reason is that request's default TLS dependency pulls in openssl which wraps the OpenSSL C-lib via openssl-sys.
    This not only adds a noticable hiccup to build times, it also requires a resp. C compiler toolchain which can be a PITA when cross-compilation for other platform targets is needed (e.g. Android or iOS).

    reqwest offers a bunch of alternative TLS backends, exposed by feature flags.

    With this PR they're all also available in the fcm_v1 crate.

  • Made clippy happy:

    • Swapped explicit for derived Default for some types.
    • Removed superfluous return.
  • Cleaned up/added docs.

…ed Default for some types, cleaned up/added docs.
@virtualritz
Copy link
Author

Ping!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant