263/Send Email to Candidates#268
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
LOTaher
requested changes
Mar 30, 2026
| candidateId: z.string().cuid(), | ||
| }); | ||
|
|
||
| export async function POST(request: NextRequest) { |
Collaborator
There was a problem hiding this comment.
Can you please create a service function to define logic, and call that service function within this controller? Simply just for code cleanliness purposes.
You can create a new EmailService file and follow the same conventions as we do in the other files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Area] - Short Description
Changes
Notes
i cant get the logo or icon svgs to appear in the email so i just disregarded for now :(
Screenshots
Checklist
Please go through all items before requesting reviewers:
Closes
Closes #263