277/Add Send Email Button#281
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| if (s === 'NOT_STARTED') return 'Not started'; | ||
| if (s === 'NOT_ASSIGNED') return 'Not assigned'; | ||
| if (s === 'EXPIRED') return 'Expired'; | ||
| if (s === 'NOT_SENT') return 'Not sent'; |
There was a problem hiding this comment.
This is a duplicate. Line 21 has he same check.
There was a problem hiding this comment.
oops sorry i added that before i pulled
| positionTitle: string; | ||
| assessmentId: string; | ||
| export async function sendAssessmentInvitation(positionId: string): Promise<{ | ||
| totalSent: number; |
There was a problem hiding this comment.
Can you define this to be its own type like we've done in other functions?
| candidateId, | ||
| session.activeOrganizationId | ||
| ); | ||
| const position = await prisma.position.findUnique({ |
There was a problem hiding this comment.
Can you make all this logic in a service function please!
|
|
||
| <TabsContent value="assessment">{/* No content yet */}</TabsContent> | ||
| <TabsContent value="assessment"> | ||
| <div className="border-sarge-gray-200 flex items-center justify-between self-stretch rounded-lg border bg-white p-4"> |
There was a problem hiding this comment.
We shouldn't hardcode an assessment here. We only need the button on the top right for now. Because we are already within a specific position page, we don't need to list it here. You should already have that data!
| ) | ||
| : candidates; | ||
|
|
||
| const handleSendAssessments = async () => { |
There was a problem hiding this comment.
Can you move this function and the rest of the values (the isSendingAssessments state variable, etc) you need to the useCandidates hook.
2 participants
[Area] - Short Description
Changes
Notes
N/A
Screenshots
Checklist
Please go through all items before requesting reviewers:
Closes
Closes #277