SearchBar Component#364
Open
vi0let-byte wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Aaryan1203
requested changes
Mar 31, 2026
Collaborator
Aaryan1203
left a comment
There was a problem hiding this comment.
can you fix the linting and formatting errors please! After that everything here looks good to go
08606bd to
0284c38
Compare
…allowing customizable placholder text
0284c38 to
765bac3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Modified existing SearchBar component to take its placeholder text as a param. This enables reuse for Rooms.
Closes
Type of Change
Please tick the boxes that best match your changes.
Testing
Please describe how you tested this PR (both manually and with tests) Provide instructions so we can reproduce.
The only thing this really affects is visuals so I clicked around on the website and made sure the placeholder was still correct.
Checklist