Allow MSE and peak error testing against source images #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Assuming the patch that fixes UBSAN, I got another UBSAN. for p1_02 and p1_03. |
|
I have tested the patch on a 32-bit environment. I got the following error. |
|
Can you run just this one: fate-jpeg2000dec-p1_04 |
Looks good (No error was generated). Do you know the reason? |
|
I implemented the MSE and peak error comparison only for that one! Look at the make file. |
palemieux
force-pushed
the
patches/update-fate
branch
from
58cd569 to
3d4a0c0
Compare
|
Where can I see the thresholds for the lossy codestreams? |
Cosmetic change in preparation for the next commit. Signed-off-by: James Almer <[email protected]>
…upported but conversion is not required Values in csp, prim, trc, etc, are irrelevant if there's no conversion needed. Reviewed-by: Niklas Haas <[email protected]> Signed-off-by: James Almer <[email protected]>
Look at line 72 at tests/fate/jpeg2000.mak |
Signed-off-by: Rémi Denis-Courmont <[email protected]>
Make the checker functions available for all codecs. Signed-off-by: Marton Balint <[email protected]>
The comments supposed to track the possible value of the qmat and qmat16 matrices, but they were not updated properly in the long history of the mpegvideo encoder. Also they wrongly assumed the usage of built-in quantizer matrices and linear quantization. Signed-off-by: Marton Balint <[email protected]>
…is_c and dct_quantize_c Fixes corruption with: ffmpeg -t 1 -filter_complex "sine=f=21,showwaves=scale=cbrt:mode=line:colors=white:draw=full" -c:v mpeg2video -non_linear_quant 1 -qmin 1 -qmax 1 -cpuflags 0 out.mpg or ffmpeg -t 1 -filter_complex "sine=f=21,showwaves=scale=cbrt:mode=line:colors=white:draw=full" -c:v mpeg2video -non_linear_quant 1 -qmin 1 -qmax 1 -trellis 1 out.mpg Signed-off-by: Marton Balint <[email protected]>
…nfigurations This was disabled in da60b99 and then accidentally re-enabled in 172b0e2. The code in question was never properly adapted for litte-endian mode. refs: trac/10955 Signed-off-by: Michael Niedermayer <[email protected]>
codec37 operates on 2 buffers, which must be considered private to the codec and must therefore not be changed by subsequent FOBJs. Let codec37 therefore operate on frm1/2 instead of frm0/2, but copy the decoded image to frm0 where other codecs operate on. Fixes artifacts encountered in Full Throttle "dazed.san" and also in a lot of Rebel Assault II gameplay videos: these videos consist of frames with an initial codec37 FOBJ image to set the stage, and optional codec1-23 FOBJs overlaid on top of that image. Signed-off-by: Manuel Lauss <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
…xtension_picky mode" The next commit implements the hls fix in a way that doesnt need this This reverts commit 54897da.
This blocks disallowed extensions from probing It also requires all available segments to have matching extensions to the format mpegts is treated independent of the extension It is recommended to set the whitelists correctly instead of depending on extensions, but this should help a bit, and this is easier to backport Fixes: CVE-2023-6602 II. HLS Force TTY Demuxer Fixes: CVE-2023-6602 IV. HLS XBIN Demuxer DoS Amplification The other parts of CVE-2023-6602 have been fixed by prior commits Found-by: Harvey Phillips of Amazon Element55 (element55) Signed-off-by: Michael Niedermayer <[email protected]>
This will be used to propagate global side data through the filterchain. Signed-off-by: James Almer <[email protected]>
This will be used to propagate global side data through the filterchain. Signed-off-by: James Almer <[email protected]>
This will be used to get global side data that was propagated through the filterchain. Signed-off-by: James Almer <[email protected]>
…he filterchain Global side data as exported by a decoder may no longer apply if a filter in the chain altered the frames in some form, like changing color, dimensions, or channel layout information. After this change, any such changes in side data will be taken into account by the encoder futher in the process. Signed-off-by: James Almer <[email protected]>
Signed-off-by: James Almer <[email protected]>
… types Signed-off-by: James Almer <[email protected]>
…esent Signed-off-by: James Almer <[email protected]>
…ta changed between frames Signed-off-by: James Almer <[email protected]>
Signed-off-by: James Almer <[email protected]>
palemieux
force-pushed
the
patches/update-fate
branch
from
3d4a0c0 to
66fe0eb
Compare
|
On 32-bit machine, I got the following: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c1p1_04-0.j2cmust be added tofate-suite\jpeg2000\itu-iso\codestreams_profile1c1p1_04-0.zip