Refactors Gulliver repository for an "intermediate" 2.0 release #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now targeting .NET Standard 2.0, .NET 8, and .NET 9. Dropping support for .NET Standard 1.3 This "modernized" version is intended to be a stutter step before any API changes before a version 3 - Updated solution and projects - Structure repository project layout - Add linting, formatting, and and applied changes - Update dependencies and removes dependencies - Adds and configure various GitHub actions for building, release, and updates - Adds miscellaneous files
…sion2RefactorTarget
rheone
requested review from
BillLudwig,
ahsteele,
drewantonich,
mabdrew,
nicksterx and
scj7t4
|
Looks good, only other thing I noticed missing is that .editorconfig doesn't have analyzer rules yet even though you deleted the ruleset files. |
scj7t4
approved these changes
Mar 3, 2025
scj7t4
left a comment
scj7t4
left a comment
There was a problem hiding this comment.
Minor spelling / documentation, might not be worth fixing in this PR
src/Gulliver/ByteArrayUtils.cs
Outdated
| public static byte[] AppendBytes([NotNull] this byte[] source, | ||
| int count, | ||
| byte element = 0x00) | ||
| /// <returns></returns> |
src/Gulliver/ByteArrayUtils.cs
Outdated
| /// <param name="right">the right side operand</param> | ||
| public static (byte[] left, byte[] right) AppendShortest([NotNull] byte[] left, | ||
| [NotNull] byte[] right) | ||
| /// <returns></returns> |
src/Gulliver/ByteArrayUtils.cs
Outdated
| /// <param name="right">the right side operand</param> | ||
| public static (byte[] left, byte[] right) PrependShortest([NotNull] byte[] left, | ||
| [NotNull] byte[] right) | ||
| /// <returns></returns> |
| /// <param name="right">the right side operand</param> | ||
| public static int CompareUnsignedBigEndian([NotNull] byte[] left, | ||
| [NotNull] byte[] right) | ||
| /// <returns></returns> |
| /// </summary> | ||
| /// <param name="input">the input bytes</param> | ||
| public static int BigEndianEffectiveLength([NotNull] this byte[] input) | ||
| /// <returns></returns> |
| } | ||
| // long.MinValue (-9223372036854775808) is a special case | ||
| // getting the absolute value of a the minimum value of a twos complement number is invalid and will cause a OverflowException | ||
| // We must therefor build the equivalent of abs(long.MinValue) big endian bytes manually |
Member
Author
There are actually 2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now targeting .NET Standard 2.0, .NET 8, and .NET 9. Dropping support for .NET Standard 1.3
This "modernized" version is intended to be a stutter step before any API changes for a potential version 3