WIP: Feature propagatable error gens #435

sserita · 2024-05-01T21:24:40Z

This is a draft PR for integrating @ashenmill's work on end-of-circuit error generators, which will probably be paired with some sort of STIM forward simulator support.

I'm opening this PR early so that I can comment on specific lines of code.

Moved some files around, integrated stim translations into pyGSTi, Added a tutorial notebook to examples

sserita · 2024-05-01T21:26:26Z

pygsti/extras/errorgenpropagation/propagatableerrorgen.py

+    def com(p1,p2):
+        P1 = pyGSTiPauli_2_stimPauli(p1)
+        P2=pyGSTiPauli_2_stimPauli(p2)
+        P3=P1*P2-P2*P1


@ashenmill Is there a specific version of STIM that is required for this? I tried subtracting PauliString objects like this on stim 1.13.0 and got unsupported operand type. Negation and addition do exist, but addition seems to just be concatenation. Am I missing something?

sserita · 2024-05-01T21:27:13Z

pygsti/extras/errorgenpropagation/propagatableerrorgen.py

+    wT=ErG1.getWeight()*ErG2.getWeight()*weightFlip*BCHweight
+
+    if ErG1.getType()=='H' and ErG2.getType()=='H':
+        pVec=com(ErG1.getP1() , ErG2.getP2())


Should this not be ErG2.getP1()? Hamiltonian error generators should only have one basis element, right?

sserita · 2024-05-01T21:27:54Z

pygsti/extras/errorgenpropagation/utilspygstistimtranslator.py

+in this function, if the weight is needed please store paulistring::weight prior to applying this function
+'''
+def stimPauli_2_pyGSTiPauli(pauliString):
+    return str(pauliString)[1:].replace('_',"I")


This line may fail if there is a complex phase because you would need to remove 2 characters.

coreyostrove · 2024-05-02T17:05:16Z

pygsti/extras/errorgenpropagation/errorpropagator.py

+MultiGate: lets the code know 
+returns: list of propagatableerrorgens
+'''
+def ErrorPropagator(circ,errorModel,MultiGateDict={},BCHOrder=1,BCHLayerwise=False,NonMarkovian=False,MultiGate=False,ErrorLayerDef=False):


Quick note to future us to remove this mutable default arg for MultiGateDict.

sserita

Just noting some discrepancies between the notes and code. It doesn't really matter if we know the code is correct, but we will eventually want some documentation for this so ensuring the notes match is probably a good step.

sserita · 2024-05-03T23:06:56Z

pygsti/extras/errorgenpropagation/propagatableerrorgen.py

+        pVec=com(ErG2.getP1() , ErG1.getP1())
+        errorGens.append( propagatableerrorgen( 'C' , [ErG2.getP1() , pVec[1]] , -1j*wT *pVec[0] ) )
+
+    elif ErG1.getType()=='H' and ErG2.getType()=='C':


Notes have this as

$$\large [H_P, C_{A,B}] = iC_{[A,P],B} + iC_{[P,B],A} $$

but what is coded is

$$\large [H_P, C_{A,B}] = iC_{[A,P],B} + iC_{\textcolor{red}{[B,P]},A} $$

I think the swapped order of the commutator introduces a sign difference, right? Which is correct?

sserita · 2024-05-03T23:12:35Z

pygsti/extras/errorgenpropagation/propagatableerrorgen.py

+    elif ErG1.getType()=='C' and ErG2.getType()=='H':
+        errorGens = commute_errors(ErG2,ErG1,weightFlip=-1.0,BCHweight=BCHweight)
+
+    elif ErG1.getType()=='H' and ErG2.getType()=='A':


Similar as [H,C]. The notes have

$$\large [H_P, A_{A,B}] = -iA_{[A,P],B} - iA_{A,[P,B]} $$

but coded is

$$\large [H_P, A_{A,B}] = -iA_{\textcolor{red}{[P,A]},B} - iA_{A,[P,B]} $$

Again, we have comm order swap in the first term with a potential sign difference. Which is correct?

sserita · 2024-05-03T23:15:38Z

pygsti/extras/errorgenpropagation/propagatableerrorgen.py

+        errorGens = commute_errors(ErG2,ErG1,weightFlip=-1.0,BCHweight=BCHweight)
+
+    elif ErG1.getType()=='S' and ErG2.getType()=='S':
+        errorGens.append( propagatableerrorgen('H', ErG1.getP1(),0 ))


Why do we add what looks like a dummy H label?

sserita · 2024-05-03T23:27:06Z

pygsti/extras/errorgenpropagation/propagatableerrorgen.py

+    elif ErG1.getType()=='S' and ErG2.getType()=='S':
+        errorGens.append( propagatableerrorgen('H', ErG1.getP1(),0 ))
+
+    elif ErG1.getType()=='S' and ErG2.getType()=='C':


Notes have

$$\large [S_P, C_{A,B}] = -iA_{AP,BP} -iA_{PB,AP} -\frac{i}{2}\big(A_{{A,B}P,P} + A_{P,P{A,B}}\big) $$

but code is

$$\large [S_P, C_{A,B}] = -iA_{\textcolor{red}{PA},BP} -iA_{PB,\textcolor{red}{PA}} -\frac{i}{2}\big(A_{{A,B}P,P} + A_{P,P{A,B}}\big) $$

Similar to the commutators, this change in multiplication could come with a sign change (depending on whether $[P,A] = 0$ and $[P,B] = 0$).
(Also we are computing ${A,B}$ twice).

sserita · 2024-05-03T23:29:51Z

pygsti/extras/errorgenpropagation/propagatableerrorgen.py

+       errorGens.append( propagatableerrorgen( 'C', [pVec1[1], pVec2[1]] , -1j*wT*pVec1[0]*pVec2[0]))
+       pVec1 = com(ErG2.getP1() , ErG2.getP2())
+       pVec2 = com(ErG1.getP1(),pVec1[1])
+       errorGens.append( propagatableerrorgen( 'A', [ErG1.getP1(), pVec2[1]] ,-.5*wT*pVec1[0]*pVec2[0]))


Note has $\frac{i}{2}$ for this weight but here it is just $\frac{1}{2}$.

sserita · 2024-05-03T23:35:43Z

pygsti/extras/errorgenpropagation/propagatableerrorgen.py

+    elif ErG1.getType() == 'A' and ErG1.getType() == 'S':
+       errorGens = commute_errors(ErG2,ErG1,weightFlip=-1.0,BCHweight=BCHweight)
+
+    elif ErG1.getType() == 'C' and ErG2.getType() == 'C':


First, I'll just say that this is way more readable with the intermediate variables. It would be even more readable if pVec* were named things like AP or acomAB or things like that.

Note has

$$\large \begin{align*} [C_{A,B}, C_{P,Q}] &= -i\big(A_{AP,QB} + A_{AQ,BP} - A_{BP,QA} - A_{BQ,PA}\big)\\ &-\frac{i}{2}\big(A_{[P,{A,B}],Q} + A_{[Q,{A,B}],P} + A_{[{P,Q},A],B} + A_{[{P,Q},B],A}\big)\\ &+\frac{i}{4}H_{[{A,B},{P,Q}]} \end{align*} $$

but coded up is

$$\large \begin{align*} [C_{A,B}, C_{P,Q}] &= -i\big(A_{AP,QB} + A_{AQ,\textcolor{red}{PB}} \textcolor{red}{+} A_{BP,QA} \textcolor{red}{+} A_{BQ,PA}\big)\\ &-\frac{i}{2}\big(A_{[P,{A,B}],Q} + A_{[Q,{A,B}],P} + A_{[{P,Q},A],B} + A_{[{P,Q},B],A}\big)\\ &+\frac{i}{4}H_{[{A,B},{P,Q}]} \end{align*} $$

Which is correct? (Also we are recomputing anticommutators)

sserita · 2024-05-03T23:40:33Z

pygsti/extras/errorgenpropagation/propagatableerrorgen.py

+        pVec1=com(P,Q)
+        pVec2=com(A,B)
+        pVec3=com(pVec1[1],pVec2[1])
+        errorGens.append( propagatableerrorgen('H',[pVec3[1]] ,.25*wT*pVec1[0]*pVec2[0]*pVec3[0]))


Notes have a factor of $\frac{i}{4}$ but this is just $\frac{1}{4}$.

sserita · 2024-05-03T23:41:47Z

pygsti/extras/errorgenpropagation/propagatableerrorgen.py

+        errorGens.append( propagatableerrorgen('C', [pVec2[1] , Q ], .5*1j*wT*pVec1[0]*pVec2[0] ))
+        pVec1 = acom(A,B)
+        pVec2 =com(Q,pVec1[1])
+        errorGens.append( propagatableerrorgen('C',[pVec2[1],P ],-.5*1j*wT*pVec1[0]*pVec2[0] ))


Notes have $-\frac{1}{2}$ but @ashenmill confirmed that the coded $-\frac{i}{2}$ is correct.

sserita · 2024-05-06T22:51:08Z

FYI, I have split off another branch from this called feature-nonstim-BCH-tools. The key difference is that the BCH tools in the branch will a) not rely on STIM and b) use existing label classes + defaultdicts to avoid the need to subclass out PropagatableErrorgen.

I'm not planning to make tools that cover all of the functionality Ashe covered, so likely some merge will be required, but I think my branch will have a pretty good idea of what these tools might look like when they are finally merged. I hope this will be at least a good discussion point for us in a week. :)

…yGSTio/pyGSTi into feature-Propagatable-ErrorGens

Added Analytic Propagation

Created an initial implementation of the error_gen Object initial implementation. Also merged a few functions from the ml branch for compressed sensing purposes.

sserita · 2025-04-01T20:37:41Z

@coreyostrove Can this PR be closed with the merge of #538? Similarly, can the branch be cleaned up (at the very least my feature-nonstim-BCH-tools can be deleted as it is obselete now)

coreyostrove · 2025-04-14T02:40:42Z

We should be able to safely close this PR, and I am pretty sure we should also be able to clean up the branch, but will defer that to @ashenmill as while I am pretty sure all of her code has been ported over to use the new implementation there is a chance she is still needs this for something.

Ashe Miller and others added 5 commits February 29, 2024 15:49

Added Propagation Code for EOC Error Generators

d3b5fe9

stim integration to pygsti

fdd689d

Moved some files around, integrated stim translations into pyGSTi, Added a tutorial notebook to examples

Added Single Error Per Gate non Markovianity

9faef8a

Fixed a bug in the non-markovianity code, added tutorial

3f5d569

added layer defined errors

582787d

sserita commented May 1, 2024

View reviewed changes

coreyostrove reviewed May 2, 2024

View reviewed changes

sserita commented May 3, 2024

View reviewed changes

Merge branch 'develop' into feature-Propagatable-ErrorGens

f8d8d19

ashenmill added 7 commits June 7, 2024 14:23

Started refactor to use dictionaries

b4a1b66

Merge branch 'feature-Propagatable-ErrorGens' of https://github.com/p…

2508fef

…yGSTio/pyGSTi into feature-Propagatable-ErrorGens

Fixed a bug in the translation code

7a5d94c

Analytic Propagation

486b690

Added Analytic Propagation

ErrorPropagator Object inital implementation

aeea377

Created an initial implementation of the error_gen Object initial implementation. Also merged a few functions from the ml branch for compressed sensing purposes.

quick bugfix

e65dc0c

improved the code for error propagation

5599e65

coreyostrove closed this Apr 14, 2025

WIP: Feature propagatable error gens #435

WIP: Feature propagatable error gens #435

Uh oh!

Conversation

sserita commented May 1, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sserita left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sserita May 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sserita commented May 6, 2024

Uh oh!

sserita commented Apr 1, 2025

Uh oh!

coreyostrove commented Apr 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sserita left a comment •

edited

Loading

sserita May 3, 2024 •

edited

Loading