Fiducial Selection Bugfix #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 2, 2025 23:03
Fix a quite old bug in the fiducial selection code. This bug (related to incorrectly skipping complement POVM effects) looks to be the reason why fiducial selection would never find the MIC fiducial set for measurements when you wanted it to.
Remove the commented out lines related to the (erroneous) ComplementPOVMEffect check. Also clean up a few misc commented out bits of code.
sserita
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a rather old bug in the fiducial selection code that I was only recently motivated to track down. This bug related to incorrectly skipping complement POVM effects when determining the rank of the Gramian for the measurement fiducials. This looks to be the reason why fiducial selection would never find the MIC fiducial set for measurements when you wanted it to which is an issue a number of folks have noticed previously. This should incidentally result in slightly smaller experiment designs in many circumstances.
Note: The old behavior wasn't wrong per se, so there is no reason to worry about the correctness of older measurement fiducial sets, they were just a bit overcomplete.